Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ClickHouse to onprem database #85

Merged
merged 4 commits into from
Mar 31, 2020
Merged

add ClickHouse to onprem database #85

merged 4 commits into from
Mar 31, 2020

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Mar 29, 2020

Signed-off-by: Slach [email protected]

@mingrammer
Copy link
Owner

Please follow the contributing guideline: https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

It doesn't seem to have been added via autogen.sh.

@mingrammer mingrammer added the kind/feat/icon Icon request label Mar 31, 2020
@Slach
Copy link
Contributor Author

Slach commented Mar 31, 2020

@mingrammer
could you suggest,
after autogen.sh run, many docs/nodes/*.md files were changed
should I add these changes too?

mingrammer
mingrammer requested changes Mar 31, 2020
View reviewed changes
diagrams/onprem/database.py Outdated Show resolved Hide resolved
@mingrammer
Copy link
Owner

Resolve the conflict please!

@Slach
Copy link
Contributor Author

Slach commented Mar 31, 2020

conflicts resolved @mingrammer please look at PR again

mingrammer
mingrammer approved these changes Mar 31, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding it :)

@mingrammer mingrammer merged commit 524b32c into mingrammer:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
kind/feat/icon Icon request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Slach @mingrammer